I have only now analysed a match with a later build and must say that I
liked it better with no text in the annotation window if gnubg didn't
find a fault with my move. It coincides better with the luck analysis on
the left hand side. Also, "good" (or any other text) raises attention
when there's imho no need because the move was ok. It's different if it
would've been outstanding, but so far we don't make that distinction.
For the internal storage I agree to have a distinction between a not
analysed and an analysed move. So for a not analysed move (or one
without annotations) SKILL_NONE should be set. For analysed moves that
are in neither way prominent I suggest SKILL_OK. Neither of both should
mark the move with !, ?, ?! in the game record and SKILL_OK should also
leave the drop down of the move analysis in the annotation window blank.
SKILL_NONE might give an entry of "not analysed".
Last, I think SKILL_VERYGOOD (and SKILL_GOOD used in this sense) should
return even if gnubg doesn't recognise a move as such and thus doesn't
set these flags. One can still set them manually for annotation purposes.
To sum it up, I'd like to see the following flags: SKILL_NONE,
SKILL_VERYBAD, SKILL_BAD, SKILL_DOUBTFUL, SKILL_OK, SKILL_GOOD and maybe
SKILL_VERYGOOD.
And while playing with this I think to have found a small bug:
It's not possible to mark a move manually as good. All other choices
work, though.