[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug-gnubg] simpleboard.c checks for HAVE_CAIRO, but implies HAVE_PANGOC
From: |
Ingo Macherius |
Subject: |
[Bug-gnubg] simpleboard.c checks for HAVE_CAIRO, but implies HAVE_PANGOCAIRO |
Date: |
Sat, 15 Aug 2009 11:50:12 +0200 |
The use of the two defines HAVE_CAIRO and HAVE_PANGOCAIRO in the autoconf
scripts hints that one can very well HAVE_CAIRO, but not HAVE_PANGOCAIRO. This
is actually the case with cygwin (1.7.0-58).
However, there is C code in the current CVS which implies from HAVE_CAIRO that
PANGOCAIRO is available just as well.
simpleboard.c:
#include "config.h"
#if HAVE_CAIRO
#include <cairo.h>
#include <pango/pangocairo.h>
#include <glib.h>
...
Indirectly affected is export.c, which conditionally includes simpleboard.h
afer only checking for HAVE_CAIRO
export.c:
#if HAVE_CAIRO
#include <cairo.h>
#include <cairo-svg.h>
#include <cairo-pdf.h>
#include <cairo-ps.h>
#include "simpleboard.h"
#endif
simpleboard.h:
#if HAVE_CAIRO
typedef struct _SimpleBoardColor SimpleBoardColor;
...
Please fix the respective #if statements to check for HAVE_PANGOCAIRO in the 3
files above.
Cheers,
Ingo
P.S. A workaround for me (I need no frigging GUI for a bot) is to simply
uninstall cairo-devel from cygwin.
- [Bug-gnubg] simpleboard.c checks for HAVE_CAIRO, but implies HAVE_PANGOCAIRO,
Ingo Macherius <=