Re: [Bug-gnubg] Latest Windows GNUBG (20110228) - problem changing languages?

[Michael Petch]

On 04/03/2011 2:28 PM, Philippe Michel wrote:
> On Fri, 4 Mar 2011, Michael Petch wrote:
>
> > I've committed a change that should fix it.
>
> You don't say haw you diagnosed it, so maybe you already know this, 
> but FWIW on linux (rhel6) the original code looped repeating these 
> messages :
>
> Your fix doesn't look directly related to gtk so maybe there are still 
> some mines in gtk code that are simply not triggered any more.
Actually I used Linux to look into the issue as well early this morning. 
I find Linux a lot easier to debug with. Those assertions and errors 
were what made me decide to look into it and realized were related to 
the apparent hang on Windows. You just don't see the console output.

While sitting in the debugger I happened to notice that "save settings" 
was being done multiple times on Language changing and eventually the UI 
started throwing the errors in a tight loop. There was no need for Save 
Settings to be done more than once (I don't think that was intended). I 
removed the extraneous call. After removal "Save Settings" is still 
called once only when you hit okay. This seems to have broken the cycle 
that was being created.

After testing with the CLI version and GUI variants I saw no adverse 
effects.

Michael