Re: [Bug-gnulib] lib/setenv.c

[Simon Josefsson]

Simon Josefsson <address@hidden> writes:

> Bruno Haible <address@hidden> writes:
>
>> Thanks for reporting this. But we are not done by taking setenv.c from
>> glibc: it does not work on AIX 4.3.3 because this platform has
>> setenv() but no unsetenv().
>>
>> For gettext, I've taken glibc's setenv.c and made a few portability
>> fixes. What do you think, can I put this into gnulib? The files are
>> attached below.
>
> It looks good.  I don't like to depend on alloca() though, but it
> seems it is not needed unless USE_TSEARCH is defined.  Thanks.  (I
> have only tested it on Linux and Solaris yet, but will test it on AIX
> 4.3.2 sooner or later too.)

I discovered that USE_TSEARCH gets defined anyway, probably via
gettext which I use, so I must add alloca.* from gnulib too even
though I never use it myself.  I think this is bad, it would be better
if each replacement function was as independent as possible.  Why
can't setenv.c use malloc() instead which is much more portable and
standards compliant than alloca()?