[Bug-gnulib] getdate and posixtm use mktime without depending on mktime

[Paul Eggert]

As part of my project to hand GNU Tar off to other maintainers, I
modified Tar to grab gnulib modules automatically, by starting with
the modules that Tar uses directly and then taking the transitive
closure of the "Depends-on" relation.  While doing this I discovered a
discrepancy: Tar's old (hand-generated) list of source files included
lib/mktime.c and m4/mktime.m4, but the gnulib dependencies didn't
reveal the need for this.  Here is a proposed patch to gnulib to add
this missing dependency.


Index: ChangeLog
===================================================================
RCS file: /cvsroot/gnulib/gnulib/ChangeLog,v
retrieving revision 1.58
diff -p -u -r1.58 ChangeLog
--- ChangeLog   26 Jun 2003 10:36:04 -0000      1.58
+++ ChangeLog   7 Jul 2003 21:48:22 -0000
@@ -1,3 +1,7 @@
+2003-07-07  Paul Eggert  <address@hidden>
+
+       * modules/getdate, modules/posixtm: Depend on mktime.
+
 2003-06-26  Bruno Haible  <address@hidden>
 
        * modules/human: Depend on module stdbool.
Index: m4/ChangeLog
===================================================================
RCS file: /cvsroot/gnulib/gnulib/m4/ChangeLog,v
retrieving revision 1.460
diff -p -u -r1.460 ChangeLog
--- m4/ChangeLog        1 Jul 2003 21:07:13 -0000       1.460
+++ m4/ChangeLog        7 Jul 2003 21:48:26 -0000
@@ -1,3 +1,8 @@
+2003-07-07  Paul Eggert  <address@hidden>
+
+       * getdate.m4 (gl_GETDATE): Require gl_FUNC_MKTIME.
+       * posixtm.m4 (gl_POSIXTM): Likewise.
+
 2003-07-01  Paul Eggert  <address@hidden>
 
        * xreadlink.m4 (gl_XREADLINK): Don't check for sys/types.h, since
Index: m4/getdate.m4
===================================================================
RCS file: /cvsroot/gnulib/gnulib/m4/getdate.m4,v
retrieving revision 1.1
diff -p -u -r1.1 getdate.m4
--- m4/getdate.m4       31 Dec 2002 13:42:06 -0000      1.1
+++ m4/getdate.m4       7 Jul 2003 21:48:27 -0000
@@ -19,5 +19,6 @@ AC_DEFUN([gl_GETDATE],
   AC_CHECK_HEADERS_ONCE(stdlib.h string.h)
   AC_CHECK_FUNCS_ONCE(isascii)
   AC_STRUCT_TIMEZONE
+  AC_REQUIRE([gl_FUNC_MKTIME])
   AC_REQUIRE([gl_TM_GMTOFF])
 ])
Index: m4/posixtm.m4
===================================================================
RCS file: /cvsroot/gnulib/gnulib/m4/posixtm.m4,v
retrieving revision 1.1
diff -p -u -r1.1 posixtm.m4
--- m4/posixtm.m4       31 Dec 2002 13:42:07 -0000      1.1
+++ m4/posixtm.m4       7 Jul 2003 21:48:27 -0000
@@ -11,4 +11,5 @@ AC_DEFUN([gl_POSIXTM],
   dnl Prerequisites of lib/posixtm.c.
   AC_STRUCT_TM
   AC_CHECK_HEADERS_ONCE(stdlib.h string.h)
+  AC_REQUIRE([gl_FUNC_MKTIME])
 ])
Index: modules/getdate
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/getdate,v
retrieving revision 1.3
diff -p -u -r1.3 getdate
--- modules/getdate     20 Jan 2003 10:02:37 -0000      1.3
+++ modules/getdate     7 Jul 2003 21:48:27 -0000
@@ -9,6 +9,7 @@ m4/tm_gmtoff.m4
 m4/getdate.m4
 
 Depends-on:
+mktime
 unlocked-io
 
 configure.ac:
Index: modules/posixtm
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/posixtm,v
retrieving revision 1.3
diff -p -u -r1.3 posixtm
--- modules/posixtm     20 Jan 2003 10:02:38 -0000      1.3
+++ modules/posixtm     7 Jul 2003 21:48:27 -0000
@@ -7,6 +7,7 @@ lib/posixtm.c
 m4/posixtm.m4
 
 Depends-on:
+mktime
 unlocked-io
 
 configure.ac: