Re: [Bug-gnulib] save-cwd.c: changed interface

[Derek Robert Price]

Jim Meyering wrote:

> FYI, I've just changed save_cwd in coreutils/lib/save-cwd.c like this:
>
>         Don't emit diagnostics.  Let callers do that.
>         * save-cwd.c: Don't include "error.h".
>         (save_cwd): Don't call error.  Ensure that errno is valid
>         when returning nonzero.
>
> I see that tar uses it, but that this change will only help tar,
> by eliminating an unnecessary diagnostic.
>
> There is another change (older in coreutils): restore_cwd
> now takes only one argument.  That too looks like it'd be
> simple to adapt to in tar.
>
> I don't know of any other package that uses save-cwd.c.
> I'd like to change it in gnulib, too.
>
> Any objections or suggestions?

CVS uses save-cwd, but it should be easy enough to adapt.  Your changes 
to save_cwd() should let me update save-cwd before I deal with 
error.{h,c}, anyhow.  Also, CVS never calls restore_cwd() with a second 
argument that isn't NULL.

Thanks!  :)

Derek

--
               *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
--
I've never made a mistake in my life.  I thought I had once, but it turned out 
that I hadn't.