bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnulib] too many FOO_exit_failure variables


From: Jim Meyering
Subject: Re: [Bug-gnulib] too many FOO_exit_failure variables
Date: Sat, 19 Jul 2003 10:17:55 +0200

Paul Eggert <address@hidden> wrote:
> Bruno Haible <address@hidden> writes:
>
>> OK, for simple modules like these, where every program wants to exit() on
>> failure, I agree that it doesn't need a multitude of variables, and a single
>> 'exit_failure' variable is enough. Very few programs use exit codes other
>> than EXIT_FAILURE anyway.
>
> Yes, I ran into this only because I was fixing 'expr', which has 4
> exit codes.
>
> Jim Meyering just reminded me that closeout also should be changed
> accordingly, so I'm also proposing the following change (which I'll
> test with coreutils before installing).
>
> 2003-07-18  Paul Eggert  <address@hidden>
>
>       * closeout.h (close_stdout_set_status, close_stdout_status): Remove.
>         * closeout.c: Likewise.  Include "closeout.h" right after config.h,
>         to test that it can stand by itself.  Include "exitfail.h".
>       Clients should set exit_failure instead.
>         (EXIT_FAILURE): Remove; no longer needed.  Do not include <stdlib.h>.

Thanks for doing that.  I've applied it.
I've also changed coreutils accordingly.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]