Re: [Bug-gnulib] 03-getndelim2-c89.diff

[Bruno Haible]

Derek Robert Price wrote:

> -getloadavg (loadavg, nelem)
> -     double loadavg[];
> -     int nelem;
> +getloadavg (double *loadavg, int nelem)

I'd prefer   "double loadavg[]"
because that's the way the libc documentation writes it, and the array
has a fixed length.

>  char *
> -getusershell ()
> +getusershell (void)

There's absolutely no point is changing function _definitions_ with
no arguments to use (void). Both ways to write it are equivalent from
the language point of view, and (void) is just useless clutter for the
human reader. Please drop this.

>  __ptr_t
> -__memchr (s, c_in, n)
> -     const __ptr_t s;
> -     int c_in;
> -     size_t n;
> +__memchr (const void *s, int c_in, size_t n)

Why do you replace one instance of __ptr_t when you keep the other one?

Bruno