Re: [Bug-gnulib] getpass echoes on many systems

[Paul Eggert]

address@hidden (Larry Jones) writes:

> The interaction between a stream and its underlying file descriptor is a
> different issue.  As I read the relevant section of POSIX, the existing
> code is OK because tcsetattr doesn't affect the file offset.

OK, thanks for the info.

The patch that was actually installed is slightly different from what
you proposed.  It includes <fcntl.h> unconditionally, and doesn't
define SEEK_CUR even if the include files define it.  The latter
change is arguably OK, as we're assuming C89 more and more.  But do we
really need to include <fcntl.h> here?

There are a few other issues with gnulib getpass.c.  The "if (in !=
stdin)" should be "if (in == out)".  And it should be merged with
glibc getpass.c.  I'll add this to my list of things to look into.