Re: [Bug-gnulib] Re: [patch] findutils-4.1.20: use d_type in struct dirent

[Jim Meyering]

James Youngman <address@hidden> wrote:
> On Thu, Mar 18, 2004 at 02:16:49PM +0000, Tim Waugh wrote:
>> Here is a patch (originally by Jakub Jelinek) to use d_type in struct
>> dirent, if available, to avoid unnecessary stat() calls in some
>> expressions.
>>
>> What do you think?
>
> It's a useful patch, but there are two things we need to think about :-
>
> 1. This includes a patch to Gnulib's savedir.c.  Gnulib guys, what do
>    you think of the Gnulib patch?

It looks like a good idea, though I have to confess that coreutils is
moving away from savedir -- and from explicit recursion for file system
traversals.  Although there still remains one use of savedir (in copy.c),
that will be removed when copy.c is rewritten to use lib/fts.c.

> 2. It's a significant piece of code, so the FSF will want a copyright
>    disclaimer before I can include the code.  Is Jakub Jelinek the only
>    author of the patch, or does it include contributions from other people
>    too?
>
> So that the Gnulib guys know what I am referring to, the
> Gnulib-specific parts of the patch appear below.  (By the way, how
> does D_TYPE_IN_DIRENT get #defined?)

There's a macro that tests for that in coreutils/m4/d-type.m4,
but it defines a slightly different name, HAVE_STRUCT_DIRENT_D_TYPE,
to be more in line with the naming convention used by autoconf's
AC_CHECK_MEMBERS.