Re: [Bug-gnulib] dos.m4 missing Cygwin

[Derek Robert Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Paul Eggert wrote:

>Derek Robert Price <address@hidden> writes:
>
>>I've included a short patch to add __CYGWIN__ to
>>the list of defines checked by m4/dos.m4.
>
>
>Thanks; I installed that (after updating the serial number and adding
>a copyright notice).

Thanks!

>Should similar changes be installed into lib/findprog.c,
>lib/localcharset.c, lib/pathname.h, and lib/progreloc.c?  They all
>seem to use expressions like "defined _WIN32 || defined __WIN32__ ||
>defined __EMX__ || defined __DJGPP__" to decide whether to support
>Microsoft-Windows-like file name syntax.


I haven't looked at the others yet, but I it looks to me like
pathname.h should probably simply depend on dos.m4 for some or all of
its DOS path handling functionality.  As things stand, it looks like
pathname.h is redefining the ISSLASH & macro and rendering itself
incompatible with the dirname module and any other module which uses
dos.m4.  It is also defining some macros which are redundant with the
dos.m4 functionality.

Some of the other macros from pathname.h, such as IS_ABSOLUTE_PATH,
could conceivably be usefully defined in dos.m4 as well.

Derek

- --
                *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFAju2dLD1OTBfyMaQRAilQAJ9clptK01UmOCdG/OjbFKrgzk207gCg8P8k
I+HmhyRNdR8hY+T0awN6eEI=
=Gp0K
-----END PGP SIGNATURE-----