[Bug-gnulib] Re: bison.m4 breaks build on systems without Bison

[Derek Robert Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Excuse me, I forgot while composing the last email that *.c files also
need to be distributed for systems without Bison when AM_MISSING_PROG
is used.  I've updated the patch to add getdate.c to EXTRA_DIST in the
module/getdate file.  I've also updated the previously incorrect date
in the ChangeLog message.

Derek

Derek Robert Price wrote:

> I suggest calling AM_MISSING_PROG(YACC, bison -y) from bison.m4 rather
> than just naively setting and substing.  Patch attached.
>
> Derek


- --
                *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFAlmGFLD1OTBfyMaQRApqTAKCgKvXkAOd+35Qv4QfQE/7WuULhtQCgm5wc
BUmO6gFNeI/r63J+M5niq6k=
=DbBG
-----END PGP SIGNATURE-----

Index: ChangeLog
===================================================================
RCS file: /cvsroot/gnulib/gnulib/ChangeLog,v
retrieving revision 1.148
diff -u -p -r1.148 ChangeLog
--- ChangeLog   27 Apr 2004 22:11:37 -0000      1.148
+++ ChangeLog   3 May 2004 15:09:22 -0000
@@ -1,3 +1,9 @@
+2004-05-03  Derek Price  <address@hidden>
+
+       * m4/bison.m4: Use AM_MISSING_PROG rather than a set/subst combination.
+       * modules/getdate (EXTRA_DIST): List getdate.c so that systems without
+       Bison may build the object file.
+
 2004-04-27  Derek Price  <address@hidden>
 
        * m4/dos.m4 (gl_AC_DOS): Add Cygwin to list of Windows/DOS
Index: m4/bison.m4
===================================================================
RCS file: /cvsroot/gnulib/gnulib/m4/bison.m4,v
retrieving revision 1.3
diff -u -p -r1.3 bison.m4
--- m4/bison.m4 18 Apr 2004 18:12:50 -0000      1.3
+++ m4/bison.m4 3 May 2004 15:09:22 -0000
@@ -3,6 +3,5 @@
 AC_DEFUN([gl_BISON],
 [
   # getdate.y works with bison only.
-  : ${YACC='bison -y'}
-  AC_SUBST(YACC)
+  AM_MISSING_PROG(YACC, bison -y)
 ])
Index: modules/getdate
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/getdate,v
retrieving revision 1.5
diff -u -p -r1.5 getdate
--- modules/getdate     31 Mar 2004 07:20:49 -0000      1.5
+++ modules/getdate     3 May 2004 15:09:22 -0000
@@ -21,6 +21,7 @@ gl_GETDATE
 Makefile.am:
 lib_SOURCES += getdate.h getdate.y
 BUILT_SOURCES += getdate.c
+EXTRA_DIST += getdate.c
 MAINTAINERCLEANFILES += getdate.c
 
 Include: