Re: [Bug-gnulib] Minor cosmetic fix for gnulib-tool generated Makefile.am

[Derek Robert Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Bruno Haible wrote:

>Derek Robert Price wrote:
>
>>## For module alloca-opt:
>>BUILT_SOURCES += $(ALLOCA_H)
>>EXTRA_DIST += alloca_.h
>
>
>I would prefer this style:
>
>
># >>> gnulib module alloca-opt.
>
>BUILT_SOURCES += $(ALLOCA_H)
>EXTRA_DIST += alloca_.h
>
># <<< gnulib module alloca-opt.
>
>
>Does this look good to you?


It's fine with me, except that it should probably use the double-#
comment which Automake removes when it generates Makefile.in, like so:

## >>> gnulib module alloca-opt.

BUILT_SOURCES += $(ALLOCA_H)
EXTRA_DIST += alloca_.h

## <<< gnulib module alloca-opt.


Otherwise, since Automake compiles the += line into a single macro
definion line and deletes the original += lines, you would have a
bunch of comments bracketing nothing in the Makefile.in:

# >>> gnulib module alloca.


# <<< gnulib module alloca.

# >>> gnulib module alloca-opt.


and so on.

This might be more complicated to do in sed too, and still notice and
skip the empty modules, though I won't know for sure until I try.  I
do have a second version of my patch which creats a temp file then
checks it wasn't all white space before it adds the comments and
copies in the contents of the temp file if you'd like that.  I'll be
out of town for a few days but if you want it and I can't find a way
to check my email tonight, I should be able to send it Wednesday or
Thursday.

Cheers,

Derek

- --
                *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFBap34LD1OTBfyMaQRAlqiAJ9xbutikGvBHyGW1Y7iXRhwSikZGgCfeKxG
awDqOsToKi6HHTnJH1OA3ug=
=ARq7
-----END PGP SIGNATURE-----