[bug-gnulib] Re: getline

[Simon Josefsson]

Paul Eggert <address@hidden> writes:

>> I'm not exactly sure what you mean by conditional compilation, though.
>> Conditional compilation of what?  Conditioned on what?
>
> Conditioned on whether it's glibc.  The idea is that glibc should not
> take any performance hit for the change.  It's OK with me if the
> gnulib version takes a minor performance hit in order to make
> maintenance easy.

The Christmas food has made me dense(r)...

Are you saying getline/getdelim when built in glibc should not use
getndelim2, so they don't take any performance hit?  Then what's the
point of adding getndelim2 to glibc?  Will the glibc maintainers
really want to maintain getndelim2, something that they don't use?

Keep in mind that the gnulib getline/getdelim aren't the same as in
libc anyway.  I don't think the glibc version work in gnulib without
several changes.

Here's an idea.  Maybe the glibc getline/getdelim code could be
modified so they optionally (when 'HAVE_GETNDELIM2') uses getndelim2,
and then the gnulib modules for getline/getdelim is synced with the
glibc implementation?  Then getndelim2 could still be GPL, and not be
part of glibc, but gnulib would get a LGPL'd getline/getdelim, by
copying the code from glibc.  This may make getline/getdelim harder to
debug (is the getndelim2 implementation used or not?), though.

Thanks.