bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gnulib] GNULIB wait-process module.


From: Derek Price
Subject: Re: [bug-gnulib] GNULIB wait-process module.
Date: Wed, 09 Mar 2005 08:39:09 -0500
User-agent: Mozilla Thunderbird 1.0 (Windows/20041206)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Bruno Haible wrote:

| Thanks for explaining. Your objective is clear now.
|
| But how would you want this to work on Woe32? I assume that you
| would want this debugging feature also on Windows. How do you
| implement it there?


Actually, the CVS server isn't completely portable to WOE32, so this
code never runs there anyhow.  Even if we do reach a point where the
server runs on WOE32 again, the fact that WCOREDUMP always evaluates
to false on WOE32 and does us no good makes me want the data dir to be
left behind on UNIX no less.  If the server does get ported
completely, then perhaps the porter will have some ideas about how to
get the same effect there.

|> The change I'm proposing is simple.  I've attached a patch.
|
|
| I'm opposed to this change because I don't see how it can be made
| to work on Windows. In other words, it makes unportable
| assumptions.


My patch is based on no new assumptions.  wait_subprocess() was
already calling WIFSIGNALED & WTERMSIG on the results of a wait.
There is code at the top of the file defining these macros to values
under WOE32 that I assume do something sensible there.  All my patch
does is, when WIFSIGNALED returned true, then set the input var to the
terminating signal via WTERMSIG, which is already being called in the
same circumstances.  The caller can then process this value.

Regards,

Derek
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCLvx8LD1OTBfyMaQRAku/AJ9RiEZBfAh7G5sHW+g/nuN3VfNl0wCgrox2
6epQNVF1oC1zRT7Sj8RaygU=
=jQYF
-----END PGP SIGNATURE-----






reply via email to

[Prev in Thread] Current Thread [Next in Thread]