bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gnulib] [PATCH]: strcasestr GnuLib module


From: Yoann Vandoorselaere
Subject: Re: [bug-gnulib] [PATCH]: strcasestr GnuLib module
Date: Mon, 15 Aug 2005 17:49:01 +0200

On Mon, 2005-08-15 at 13:28 +0200, Bruno Haible wrote:
> Hi,
> 
> Yoann Vandoorselaere wrote:
> > Attached is a patch that implement strcasestr() in GNUlib.
> 
> Your implementation, like the one in glibc, does not work correctly in
> multibyte locales.
> 
> I'm not sure it's useful to add more functions to gnulib that do not work
> correctly in multibyte locales. Yes we added strcasecmp and strncasecmp,
> because they are POSIX. But strcasestr is not in POSIX.
> 
> Instead, can you write an implementation that _does_ work correctly even
> in BIG5 locales? And then use it unconditionally in gnulib, not only
> #if !HAVE_STRCASESTR.

Hi Bruno,

As you can see from the code, this strcasestr implementation rely on
strcasecmp (I did not  bothered to use the GLIBC implementation). 

Thus, wouldn't it be wise to fix strcasecmp itself, and include it
unconditionally in GnuLib ?

-- 
Yoann Vandoorselaere <address@hidden>





reply via email to

[Prev in Thread] Current Thread [Next in Thread]