bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: config.h inclusion


From: Ralf Wildenhues
Subject: Re: config.h inclusion
Date: Fri, 16 Sep 2005 18:00:12 +0200
User-agent: Mutt/1.4.1i

Hi Paul, Noah,

* Paul Eggert wrote on Thu, Sep 15, 2005 at 04:56:04PM CEST:
> Ralf Wildenhues <address@hidden> writes:
> 
> > I learned about this issue while actually trying to make use of a module
> > with one of the unguarded files; I did not use AC_CONFIG_HEADERS.
> 
> Ok, sorry, I didn't know people still did that.  In that case, let's
> keep the #if.
> 
> > Surely there are also reasons for `#if'.
> 
> Yes: basically it's easier to read.  But given your list of problems
> we might as well stick with #ifdef.  It's no big deal either way.

OK.  Here's the second patch updated, then.  (The first and third from
my other post are now either agreed upon, I guess :)

Cheers,
Ralf

        * __fpending.h, argp-fmtstream.h, dirfd.h, getdate.h, human.h,
        inttostr.h:  Removed inclusion of config.h from header files.
        * inttostr.c:  Adjusted in-tree users.
        * timespec.h: Remove superfluous warning to include config.h.

Attachment: config-h-not-in-headers-2.diff
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]