bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: getaddrinfo.h: HAVE_SYS_TYPES_H needed?


From: Jim Meyering
Subject: Re: getaddrinfo.h: HAVE_SYS_TYPES_H needed?
Date: Wed, 05 Oct 2005 09:57:45 +0200

>> I don't see any other uses of HAVE_SYS_TYPES_H in gnulib.
>
> I removed the check.

Thanks!

>> How about HAVE_SYS_SOCKET_H?
>> At least poll.c uses <sys/socket.h> without the conditional.
>>
>> It's best to avoid the conditionals, when possible.
>
> Mingw32 doesn't have sys/socket.h, but gnulib doesn't support it
> anyway, so I removed the check.  The proper fix on mingw32 would be to
> supply, in a gnulib module, some working sys/socket.h files.
>
> What about netdb.h then?  Is there any system that lack it?

I don't know, but do see that gai_strerror.c includes it unconditionally,
so removing that conditional is probably fine, too.

> I'm leaving the tests in getaddrinfo.m4 for a while, so that more
> debug information end up in config.log.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]