Re: [bug-gnulib] memxor

[Bruno Haible]

Simon Josefsson wrote:
> Ok to install?

Yes. I'd try to help the compilers with not-so-good loop optimizers by
changing

     for (i = 0; i < n; i++)
       d[i] ^= s[i];

into

     for (; n > 0; n--)
       *d++ ^= *s++;

but that's a detail. Also the comment in memxor.h should say what
memxor does and what the return value is.

> I am not sure about the prototype.  Should it use 'char*'?  'int*'?

'void*' is fine, analogous to memset. 'char*' is also acceptable.
'int*' implies different alignment requirements and is therefore less general.

Bruno