bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gnulib] crc


From: Bruno Haible
Subject: Re: [bug-gnulib] crc
Date: Fri, 7 Oct 2005 22:37:10 +0200
User-agent: KMail/1.5

Simon Josefsson wrote:
> Ok to install?

> +/* Compute CRC-32 value of LEN bytes long BUF, and return it. */
> +extern unsigned long crc32 (char *buf, size_t len);
> ...

All 4 functions don't write into buf, therefore the 'buf' argument type should
be 'const char *', not 'char *'.

> +   Due to historic implementatio errrs, this variant is sometimes used
> ...
> +   initial and final XOR operation.  Due to historic implementatio
> +   errrs, this variant is sometimes used (i.e., in RFC 3961).  */

4 typos in comments.

Bruno





reply via email to

[Prev in Thread] Current Thread [Next in Thread]