bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: rijndael


From: Simon Josefsson
Subject: Re: rijndael
Date: Fri, 14 Oct 2005 14:39:50 +0200
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux)

Jim Meyering <address@hidden> writes:

> Simon Josefsson <address@hidden> wrote:
>> Ok to install?
>>
>> Comments appreciated, of course.
>
> Hi Simon,
>
> In this function,
>
> +rijndael_rc
> +rijndaelMakeKey (rijndaelKeyInstance * key, rijndael_direction direction,
> +              int keyLen, char *keyMaterial)
>
> the keyMaterial parameter should be `const'.
>
> And in this one, both key and input be const, too.
> There are others like this.

I have fixed this throughout the file.  I changed the type of KEYLEN
to size_t as well.

Thanks!

>
>> +int
>> +rijndaelPadEncrypt (rijndaelCipherInstance * cipher,
>> +                rijndaelKeyInstance * key, unsigned char *input,
>> +                int inputOctets, unsigned char *outBuffer)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]