Re: rijndael

[Simon Josefsson]

Jim Meyering <address@hidden> writes:

>>>> +int
>>>> +rijndaelPadEncrypt (rijndaelCipherInstance * cipher,
>>>> +              rijndaelKeyInstance * key, unsigned char *input,
>>>> +              int inputOctets, unsigned char *outBuffer)
>
> Hmm... looking at that in isolation, I wonder if `inputOctets'
> should be of type size_t, too?

Right.  I should convert a few other 'int's inside the functions to
size_t as well.  Will post an updated patch when I'm finished.

And I should turn 'unsigned char*' into 'char*'..

> Also, from a formatting standpoint, there should be no space after
> the `*'s above, e.g.:
>
> +rijndaelPadEncrypt (rijndaelCipherInstance *cipher,
> +                 rijndaelKeyInstance *key, unsigned char *input,
> +                 int inputOctets, unsigned char *outBuffer)
>
> If you're using GNU indent, you can make it do the right
> thing by adding lines like these to ~/.indent.pro
>
> -TrijndaelCipherInstance
> -TrijndaelKeyInstance
>
> for all affected types.

Works fine, thanks!

Shouldn't indent be able to work this out by itself?  Is there ever a
reason to put a space there?

Thanks.