Re: rijndael

[Jim Meyering]

Simon Josefsson <address@hidden> wrote:
> Jim Meyering <address@hidden> writes:
>
>> Simon Josefsson <address@hidden> wrote:
>>> Revised patch.
>>
>> Do those `U' suffixes serve any purpose,
>> given an array base type of uint32_t?
>
> I don't know.  Should I remove them?

Please do.
I suspect they were required initially,
probably because the base type was once signed.

>>> Index: lib/rijndael-alg-fst.c
>> ...
>>> +static const uint32_t Te0[256] = {
>>> +  0xc66363a5U, 0xf87c7c84U, 0xee777799U, 0xf67b7b8dU,
>>> +  0xfff2f20dU, 0xd66b6bbdU, 0xde6f6fb1U, 0x91c5c554U,