Re: socklen_t

[Ben Pfaff]

Paul Eggert <address@hidden> writes:

> You're welcome.  One thing I forgot to mention: the old m4/socklen.m4
> code is obviously incorrect because of the stray parenthesis in this
> line:
>
> #endif)
>
> That parenthesis is copied into the C header used for testing.
>
> GCC doesn't mind, but other compilers do (as they are entitled to).

For what it's worth, recent GCC has a warning option for this:

`-Wendif-labels'
     Warn whenever an `#else' or an `#endif' are followed by
     text.  This usually happens in code of the form

          #if FOO
          ...
          #else FOO
          ...
          #endif FOO

     The second and third `FOO' should be in comments, but often
     are not in older programs.  This warning is on by default.

-- 
"...In the UNIX world, people tend to interpret `non-technical user'
 as meaning someone who's only ever written one device driver."
--Daniel Pead