Re: [bug-gnulib] Unconditionally call AC_PROG_RANLIB?

[Bruno Haible]

Simon Josefsson wrote on 2005-12-01:
> I'm setting this up in a separate directory.  Running autoconf
> on the gnulib generated stuff results in:
> 
> lib/Makefile.am:15: library used but `RANLIB' is undefined
> lib/Makefile.am:15:
> lib/Makefile.am:15: The usual way to define `RANLIB' is to add 
> `AC_PROG_RANLIB'
> lib/Makefile.am:15: to `configure.ac' and run `autoconf' again.
> 
> Should AC_PROG_RANLIB be called from gl_INIT?

Yes. From gl_INIT or gl_EARLY. I'm committing this patch, that makes
"gnulib-tool --import" more consistent with "gnulib-tool --create-testdir".

Bruno


2006-01-07  Bruno Haible  <address@hidden>

        * gnulib-tool (func_import): Add an AC_PROG_RANLIB dependency to
        gl_EARLY.

*** gnulib-tool.bak     2005-12-02 14:37:34.000000000 +0100
--- gnulib-tool 2006-01-07 16:41:09.000000000 +0100
***************
*** 1,6 ****
  #! /bin/sh
  #
! # Copyright (C) 2002, 2003, 2004, 2005 Free Software Foundation, Inc.
  #
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,6 ----
  #! /bin/sh
  #
! # Copyright (C) 2002-2006 Free Software Foundation, Inc.
  #
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
***************
*** 1242,1247 ****
--- 1242,1248 ----
      echo "# any checks for libraries, header files, types and library 
functions."
      echo "AC_DEFUN([${macro_prefix}_EARLY],"
      echo "["
+     echo "  AC_REQUIRE([AC_PROG_RANLIB])"
      if grep AC_GNU_SOURCE "$destdir"/$m4base/*.m4 > /dev/null; then
        echo "  AC_REQUIRE([AC_GNU_SOURCE])"
      fi
***************
*** 1255,1263 ****
      echo "AC_DEFUN([${macro_prefix}_INIT],"
      echo "["
      if test -z "$libtool"; then
!       echo "AM_CONDITIONAL([GL_COND_LIBTOOL], [false])"
      else
!       echo "AM_CONDITIONAL([GL_COND_LIBTOOL], [true])"
      fi
      for module in $modules; do
        func_verify_module
--- 1256,1264 ----
      echo "AC_DEFUN([${macro_prefix}_INIT],"
      echo "["
      if test -z "$libtool"; then
!       echo "  AM_CONDITIONAL([GL_COND_LIBTOOL], [false])"
      else
!       echo "  AM_CONDITIONAL([GL_COND_LIBTOOL], [true])"
      fi
      for module in $modules; do
        func_verify_module