bug in memcoll module

[Bruno Haible]

Hi Paul,

This commit

2002-12-31  Paul Eggert  <address@hidden>

        * memcoll.m4 (gl_MEMCOLL): Require AC_FUNC_MEMCMP.

causes a gnulib-tool error:

$ ./gnulib-tool --create-testdir --dir=testdir memcoll
Module list with included dependencies:
  memcoll
File list:
  lib/memcoll.c
  lib/memcoll.h
  m4/memcoll.m4
  m4/onceonly_2_57.m4
executing autoreconf --force --install
configure.ac: installing `build-aux/install-sh'
configure.ac: installing `build-aux/missing'
lib/Makefile.am:17: required file `lib/memcmp.c' not found
autoreconf: automake failed with exit status: 1

Actually, memcoll.m4 should require gl_FUNC_MEMCMP, not AC_FUNC_MEMCMP,
since it is meant to use the memcmp.c replacement.

IMO, the fix depends whether you trust memcmp() these days.
If yes, then do not require AC_FUNC_MEMCMP.
If no, then make a dependency from 'memcoll' to 'memcmp'. And then you don't
       need to require AC_FUNC_MEMCMP either, since the gnulib-tool
       dependency mechanism will take care of invoking gl_FUNC_MEMCMP.

In either case, the appended patch should be part of the fix.

Bruno


*** m4/memcoll.m4.bak   2005-03-22 15:39:12.000000000 +0100
--- m4/memcoll.m4       2006-01-08 15:05:26.000000000 +0100
***************
*** 1,5 ****
! # memcoll.m4 serial 5
! dnl Copyright (C) 2002, 2003, 2005 Free Software Foundation, Inc.
  dnl This file is free software; the Free Software Foundation
  dnl gives unlimited permission to copy and/or distribute it,
  dnl with or without modifications, as long as this notice is preserved.
--- 1,5 ----
! # memcoll.m4 serial 6
! dnl Copyright (C) 2002, 2003, 2005, 2006 Free Software Foundation, Inc.
  dnl This file is free software; the Free Software Foundation
  dnl gives unlimited permission to copy and/or distribute it,
  dnl with or without modifications, as long as this notice is preserved.
***************
*** 10,15 ****
    AC_LIBOBJ([memcoll])
  
    dnl Prerequisites of lib/memcoll.c.
-   AC_REQUIRE([AC_FUNC_MEMCMP])
    AC_FUNC_STRCOLL
  ])
--- 10,14 ----