$(EXEEXT) in TESTS required?

[Simon Josefsson]

While testing mingw32 portability (GNU SASL now builds cleanly 
cross-compiled to mingw32!) I encountered the following.  It seems 
$(EXEXT) is required for automake TESTS variables, otherwise 
'make' misses out all CPPFLAGS etc:  make  check-TESTS make[2]: 
Entering directory `/home/jas/src/gsasl/lib/tests' 
i586-mingw32msvc-gcc -g -O2    test-gc-md5.c   -o test-gc-md5 
test-gc-md5.c:26:16: gc.h: No such file or directory 
test-gc-md5.c: In function `main': ...   If I change  TESTS += 
test-gc-md5  into  TESTS += test-gc-md5$(EXEEXT)  it works fine. 
Perhaps this is a automake bug?  OTOH, TESTS could conceivable 
contain shell scripts which shouldn't have $(EXEEXT) appended to 
it.  I think the design of the TESTS automake variable is 
sub-optimal, it leads to file name duplication, compare a typical 
*-tests module:  TESTS += test-gc-md5$(EXEEXT) noinst_PROGRAMS += 
test-gc-md5 test_gc_md5_SOURCES = test-gc-md5.c  That seem rather 
superflous.   Ideas welcome.  Meanwhile, I have installed the 
patch below.   Thanks, Simon  2006-01-18  Simon Josefsson 
<address@hidden> 

	* modules/arcfour-tests, modules/arctwo-tests, 
	modules/crc-tests, modules/des-tests, 
	modules/gc-arcfour-tests, modules/gc-arctwo-tests, 
	modules/gc-des-tests, modules/gc-hmac-md5-tests, 
	modules/gc-hmac-sha1-tests, modules/gc-md2-tests, 
	modules/gc-md4-tests, modules/gc-md5-tests, 
	modules/gc-pbkdf2-sha1-tests, modules/gc-rijndael-tests, 
	modules/gc-sha1-tests, modules/gc-tests, 
	modules/hmac-md5-tests, modules/hmac-sha1-tests, 
	modules/md2-tests, modules/md4-tests, modules/md5-tests, 
	modules/readline, modules/rijndael-tests: Add $(EXEEXT) to 
	automake TESTS variable, for mingw32.

Index: arcfour-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/arcfour-tests,v
retrieving revision 1.1
diff -u -p -r1.1 arcfour-tests
--- arcfour-tests       15 Oct 2005 18:19:45 -0000      1.1
+++ arcfour-tests       18 Jan 2006 12:59:31 -0000
@@ -6,6 +6,6 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-arcfour
+TESTS += test-arcfour$(EXEEXT)
noinst_PROGRAMS += test-arcfour
test_arcfour_SOURCES = test-arcfour.c
Index: arctwo-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/arctwo-tests,v
retrieving revision 1.1
diff -u -p -r1.1 arctwo-tests
--- arctwo-tests        21 Oct 2005 12:03:17 -0000      1.1
+++ arctwo-tests        18 Jan 2006 12:59:31 -0000
@@ -6,6 +6,6 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-arctwo
+TESTS += test-arctwo$(EXEEXT)
noinst_PROGRAMS += test-arctwo
test_arctwo_SOURCES = test-arctwo.c
Index: crc-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/crc-tests,v
retrieving revision 1.1
diff -u -p -r1.1 crc-tests
--- crc-tests   11 Oct 2005 18:25:51 -0000      1.1
+++ crc-tests   18 Jan 2006 12:59:31 -0000
@@ -6,6 +6,6 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-crc
+TESTS += test-crc$(EXEEXT)
noinst_PROGRAMS += test-crc
test_crc_SOURCES = test-crc.c
Index: des-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/des-tests,v
retrieving revision 1.2
diff -u -p -r1.2 des-tests
--- des-tests   9 Jan 2006 14:10:09 -0000       1.2
+++ des-tests   18 Jan 2006 12:59:31 -0000
@@ -6,7 +6,7 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-des
+TESTS += test-des$(EXEEXT)
noinst_PROGRAMS += test-des
test_des_SOURCES = test-des.c

Index: gc-arcfour-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/gc-arcfour-tests,v
retrieving revision 1.2
diff -u -p -r1.2 gc-arcfour-tests
--- gc-arcfour-tests    9 Jan 2006 14:10:09 -0000       1.2
+++ gc-arcfour-tests    18 Jan 2006 12:59:31 -0000
@@ -6,7 +6,7 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-gc-arcfour
+TESTS += test-gc-arcfour$(EXEEXT)
noinst_PROGRAMS += test-gc-arcfour
test_gc_arcfour_SOURCES = test-gc-arcfour.c

Index: gc-arctwo-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/gc-arctwo-tests,v
retrieving revision 1.2
diff -u -p -r1.2 gc-arctwo-tests
--- gc-arctwo-tests     9 Jan 2006 14:10:09 -0000       1.2
+++ gc-arctwo-tests     18 Jan 2006 12:59:31 -0000
@@ -6,7 +6,7 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-gc-arctwo
+TESTS += test-gc-arctwo$(EXEEXT)
noinst_PROGRAMS += test-gc-arctwo
test_gc_arctwo_SOURCES = test-gc-arctwo.c

Index: gc-des-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/gc-des-tests,v
retrieving revision 1.2
diff -u -p -r1.2 gc-des-tests
--- gc-des-tests        9 Jan 2006 14:10:09 -0000       1.2
+++ gc-des-tests        18 Jan 2006 12:59:31 -0000
@@ -6,7 +6,7 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-gc-des
+TESTS += test-gc-des$(EXEEXT)
noinst_PROGRAMS += test-gc-des
test_gc_des_SOURCES = test-gc-des.c

Index: gc-hmac-md5-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/gc-hmac-md5-tests,v
retrieving revision 1.2
diff -u -p -r1.2 gc-hmac-md5-tests
--- gc-hmac-md5-tests   9 Jan 2006 14:10:09 -0000       1.2
+++ gc-hmac-md5-tests   18 Jan 2006 12:59:31 -0000
@@ -6,7 +6,7 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-gc-hmac-md5
+TESTS += test-gc-hmac-md5$(EXEEXT)
noinst_PROGRAMS += test-gc-hmac-md5
test_gc_hmac_md5_SOURCES = test-gc-hmac-md5.c

Index: gc-hmac-sha1-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/gc-hmac-sha1-tests,v
retrieving revision 1.2
diff -u -p -r1.2 gc-hmac-sha1-tests
--- gc-hmac-sha1-tests  9 Jan 2006 14:10:09 -0000       1.2
+++ gc-hmac-sha1-tests  18 Jan 2006 12:59:31 -0000
@@ -6,7 +6,7 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-gc-hmac-sha1
+TESTS += test-gc-hmac-sha1$(EXEEXT)
noinst_PROGRAMS += test-gc-hmac-sha1
test_gc_hmac_sha1_SOURCES = test-gc-hmac-sha1.c

Index: gc-md2-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/gc-md2-tests,v
retrieving revision 1.2
diff -u -p -r1.2 gc-md2-tests
--- gc-md2-tests        9 Jan 2006 14:10:09 -0000       1.2
+++ gc-md2-tests        18 Jan 2006 12:59:31 -0000
@@ -6,7 +6,7 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-gc-md2
+TESTS += test-gc-md2$(EXEEXT)
noinst_PROGRAMS += test-gc-md2
test_gc_md2_SOURCES = test-gc-md2.c

Index: gc-md4-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/gc-md4-tests,v
retrieving revision 1.2
diff -u -p -r1.2 gc-md4-tests
--- gc-md4-tests        9 Jan 2006 14:10:09 -0000       1.2
+++ gc-md4-tests        18 Jan 2006 12:59:31 -0000
@@ -6,7 +6,7 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-gc-md4
+TESTS += test-gc-md4$(EXEEXT)
noinst_PROGRAMS += test-gc-md4
test_gc_md4_SOURCES = test-gc-md4.c

Index: gc-md5-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/gc-md5-tests,v
retrieving revision 1.2
diff -u -p -r1.2 gc-md5-tests
--- gc-md5-tests        9 Jan 2006 14:10:09 -0000       1.2
+++ gc-md5-tests        18 Jan 2006 12:59:31 -0000
@@ -6,7 +6,7 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-gc-md5
+TESTS += test-gc-md5$(EXEEXT)
noinst_PROGRAMS += test-gc-md5
test_gc_md5_SOURCES = test-gc-md5.c

Index: gc-pbkdf2-sha1-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/gc-pbkdf2-sha1-tests,v
retrieving revision 1.2
diff -u -p -r1.2 gc-pbkdf2-sha1-tests
--- gc-pbkdf2-sha1-tests        9 Jan 2006 14:10:09 -0000       1.2
+++ gc-pbkdf2-sha1-tests        18 Jan 2006 12:59:31 -0000
@@ -6,7 +6,7 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-gc-pbkdf2-sha1
+TESTS += test-gc-pbkdf2-sha1$(EXEEXT)
noinst_PROGRAMS += test-gc-pbkdf2-sha1
test_gc_pbkdf2_sha1_SOURCES = test-gc-pbkdf2-sha1.c

Index: gc-rijndael-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/gc-rijndael-tests,v
retrieving revision 1.2
diff -u -p -r1.2 gc-rijndael-tests
--- gc-rijndael-tests   9 Jan 2006 14:10:09 -0000       1.2
+++ gc-rijndael-tests   18 Jan 2006 12:59:31 -0000
@@ -6,7 +6,7 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-gc-rijndael
+TESTS += test-gc-rijndael$(EXEEXT)
noinst_PROGRAMS += test-gc-rijndael
test_gc_rijndael_SOURCES = test-gc-rijndael.c

Index: gc-sha1-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/gc-sha1-tests,v
retrieving revision 1.2
diff -u -p -r1.2 gc-sha1-tests
--- gc-sha1-tests       9 Jan 2006 14:10:09 -0000       1.2
+++ gc-sha1-tests       18 Jan 2006 12:59:31 -0000
@@ -6,7 +6,7 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-gc-sha1
+TESTS += test-gc-sha1$(EXEEXT)
noinst_PROGRAMS += test-gc-sha1
test_gc_sha1_SOURCES = test-gc-sha1.c

Index: gc-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/gc-tests,v
retrieving revision 1.2
diff -u -p -r1.2 gc-tests
--- gc-tests    9 Jan 2006 14:10:09 -0000       1.2
+++ gc-tests    18 Jan 2006 12:59:31 -0000
@@ -6,7 +6,7 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-gc
+TESTS += test-gc$(EXEEXT)
noinst_PROGRAMS += test-gc
test_gc_SOURCES = test-gc.c

Index: hmac-md5-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/hmac-md5-tests,v
retrieving revision 1.1
diff -u -p -r1.1 hmac-md5-tests
--- hmac-md5-tests      6 Oct 2005 15:58:27 -0000       1.1
+++ hmac-md5-tests      18 Jan 2006 12:59:31 -0000
@@ -6,6 +6,6 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-hmac-md5
+TESTS += test-hmac-md5$(EXEEXT)
noinst_PROGRAMS += test-hmac-md5
test_hmac_md5_SOURCES = test-hmac-md5.c
Index: hmac-sha1-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/hmac-sha1-tests,v
retrieving revision 1.1
diff -u -p -r1.1 hmac-sha1-tests
--- hmac-sha1-tests     12 Oct 2005 01:33:44 -0000      1.1
+++ hmac-sha1-tests     18 Jan 2006 12:59:31 -0000
@@ -6,6 +6,6 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-hmac-sha1
+TESTS += test-hmac-sha1$(EXEEXT)
noinst_PROGRAMS += test-hmac-sha1
test_hmac_sha1_SOURCES = test-hmac-sha1.c
Index: md2-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/md2-tests,v
retrieving revision 1.2
diff -u -p -r1.2 md2-tests
--- md2-tests   9 Jan 2006 14:10:09 -0000       1.2
+++ md2-tests   18 Jan 2006 12:59:31 -0000
@@ -6,7 +6,7 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-md2
+TESTS += test-md2$(EXEEXT)
noinst_PROGRAMS += test-md2
test_md2_SOURCES = test-md2.c

Index: md4-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/md4-tests,v
retrieving revision 1.2
diff -u -p -r1.2 md4-tests
--- md4-tests   9 Jan 2006 14:10:09 -0000       1.2
+++ md4-tests   18 Jan 2006 12:59:31 -0000
@@ -6,7 +6,7 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-md4
+TESTS += test-md4$(EXEEXT)
noinst_PROGRAMS += test-md4
test_md4_SOURCES = test-md4.c

Index: md5-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/md5-tests,v
retrieving revision 1.1
diff -u -p -r1.1 md5-tests
--- md5-tests   18 Oct 2005 14:10:28 -0000      1.1
+++ md5-tests   18 Jan 2006 12:59:31 -0000
@@ -6,6 +6,6 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-md5
+TESTS += test-md5$(EXEEXT)
noinst_PROGRAMS += test-md5
test_md5_SOURCES = test-md5.c
Index: rijndael-tests
===================================================================
RCS file: /sources/gnulib/gnulib/modules/rijndael-tests,v
retrieving revision 1.1
diff -u -p -r1.1 rijndael-tests
--- rijndael-tests      15 Oct 2005 18:21:59 -0000      1.1
+++ rijndael-tests      18 Jan 2006 12:59:31 -0000
@@ -6,6 +6,6 @@ Depends-on:
configure.ac:

Makefile.am:
-TESTS += test-rijndael
+TESTS += test-rijndael$(EXEEXT)
noinst_PROGRAMS += test-rijndael
test_rijndael_SOURCES = test-rijndael.c