bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: strfile: new module


From: Ralf Wildenhues
Subject: Re: strfile: new module
Date: Sat, 27 May 2006 12:32:06 +0200
User-agent: Mutt/1.5.11+cvs20060403

* Ralf Wildenhues wrote on Sat, May 27, 2006 at 12:22:35PM CEST:
> * Simon Josefsson wrote on Sat, May 27, 2006 at 12:12:59PM CEST:
> > +   int save_errno = errno;
> 
> You are using errno but not including <errno.h>.

...and realloc but not including <stdlib.h>.
Please compile your code with lots of warnings enabled.
You pass NULL to realloc and possibly to free but are not
depending on the realloc and free modules.

I wonder whether you want to read it in text or in binary
mode (for Cygwin...).

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]