bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Misleading cast in glob.c


From: Larry Jones
Subject: Misleading cast in glob.c
Date: Wed, 21 Jun 2006 14:52:29 -0400 (EDT)

There are casts in glob.c that contain ineffective const's that some
compilers warn about:

Index: glob.c
===================================================================
RCS file: /cvsroot/cvs/ccvs/lib/glob.c,v
retrieving revision 1.18
diff -u -r1.18 glob.c
--- glob.c      20 Mar 2006 02:21:56 -0000      1.18
+++ glob.c      21 Jun 2006 18:25:45 -0000
@@ -909,8 +909,8 @@
 static int
 collated_compare (const void *a, const void *b)
 {
-  const char *const s1 = *(const char *const * const) a;
-  const char *const s2 = *(const char *const * const) b;
+  const char *const s1 = *(const char *const *) a;
+  const char *const s2 = *(const char *const *) b;
 
   if (s1 == s2)
     return 0;

-Larry Jones

Isn't it sad how some people's grip on their lives is so precarious
that they'll embrace any preposterous delusion rather than face an
occasional bleak truth? -- Calvin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]