Re: inet_ntop module proposed patch

[Simon Josefsson]

Bruno Haible <address@hidden> writes:

> Hi Yoann and Simon,
>
> I propose to use #if HAVE_... instead of #ifdef HAVE_..., as customary in
> gnulib (with the exception of HAVE_CONFIG_H).

Oops!  Please install it.

Maybe those modules should depend on the new arpa_inet module instead
of having those HAVE_ARPA_INET_H tests at all.

/Simon

> diff -r -c3 --exclude=CVS gnulib-20060614-modified/lib/inet_ntop.h 
> gnulib-20060628-modified/lib/inet_ntop.h
> *** gnulib-20060614-modified/lib/inet_ntop.h  2006-01-23 15:52:00.000000000 
> +0100
> --- gnulib-20060628-modified/lib/inet_ntop.h  2006-06-29 00:15:15.000000000 
> +0200
> ***************
> *** 17,23 ****
>   
>   #include <sys/types.h>
>   #include <sys/socket.h>
> ! #ifdef HAVE_ARPA_INET_H
>   # include <arpa/inet.h>
>   #endif
>   
> --- 17,23 ----
>   
>   #include <sys/types.h>
>   #include <sys/socket.h>
> ! #if HAVE_ARPA_INET_H
>   # include <arpa/inet.h>
>   #endif
>