bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: coreutils merge into gnulib


From: Eric Blake
Subject: Re: coreutils merge into gnulib
Date: Mon, 3 Jul 2006 17:49:58 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

Mark D. Baushke <mdb <at> gnu.org> writes:

> 
> The modules/dirname seems to now depend on xstrndup

Yes.  My original proposal for the change to dirname (was it last November?) 
added this dependency; coreutils was already using xstrndup so Paul missed it.

By the way, note that ALL programs that use base_name() from the dirname module 
now need to check for memory leaks.  I know that at least tar and findutils are 
affected, as I had prepared patches for them with my original proposal.

>  lib/basename.c
>  lib/stripslash.c
> +lib/xstrndup.h

Not necessary; having the module dependency does this for you.

>  m4/dos.m4
>  m4/dirname.m4
>  m4/double-slash-root.m4
>  <at>  <at>  -13,6 +14,7  <at>  <at>  m4/double-slash-root.m4
>  Depends-on:
>  xalloc
>  stdbool
> +xstrndup

Checked in.

> 
>  configure.ac:
>  gl_DIRNAME
>  <at>  <at>  -22,6 +24,7  <at>  <at>  lib_SOURCES += basename.c stripslash.c
> 
>  Include:
>  "dirname.h"
> +"xstrndup.h"

Not necessary, same as above.

-- 
Eric Blake







reply via email to

[Prev in Thread] Current Thread [Next in Thread]