Re: Fix chdir-long.m4 caching (was: megatest fallout)

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Ralf Wildenhues on 9/25/2006 2:03 PM:
> Hello Jim,
> 
>>       7 checking whether this system has an arbitrary file name length 
>> limit... yes
> 
> OK to apply this patch?  I think this variable isn't used elsewhere in
> gnulib nor coreutils, so renaming this shouldn't be a problem.

How about covering our tracks so this won't happen again?

2006-09-25  Eric Blake  <address@hidden>

        * lib/autoconf/general.m4 (AC_CACHE_VAL): Warn if cache-id is not
        cached.

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFGJLa84KuGfSFAYARAmFyAKCO6c9SAlf5VPQV8Cpf8Zpy9NekAwCfaP/6
P0OZoxGRqau7wwh5WNromK8=
=DMRt
-----END PGP SIGNATURE-----

Index: lib/autoconf/general.m4
===================================================================
RCS file: /sources/autoconf/autoconf/lib/autoconf/general.m4,v
retrieving revision 1.930
diff -u -p -r1.930 general.m4
--- lib/autoconf/general.m4     14 Sep 2006 09:40:59 -0000      1.930
+++ lib/autoconf/general.m4     26 Sep 2006 02:38:20 -0000
@@ -1905,7 +1905,10 @@ rm -f confcache[]dnl
 # The name of shell var CACHE-ID must contain `_cv_' in order to get saved.
 # Should be dnl'ed.  Try to catch common mistakes.
 m4_defun([AC_CACHE_VAL],
-[m4_bmatch([$2], [AC_DEFINE],
+[m4_bmatch([$1], [_cv_],
+          [AC_DIAGNOSE([syntax],
+[$0($1, ...): suspicious cache-id, must contain _cv_ to be cached])])dnl
+m4_bmatch([$2], [AC_DEFINE],
           [AC_DIAGNOSE([syntax],
 [$0($1, ...): suspicious presence of an AC_DEFINE in the second argument, ]dnl
 [where no actions should be taken])])dnl