Re: another hello pretest

[Eric Blake]

Karl Berry <karl <at> freefriends.org> writes:

> 
> I put another hello pretest at
> ftp://alpha.gnu.org/gnu/hello/hello-2.1.93.tar.bz2 (and .gz).
> 
> Besides the various patches, I tried to delete CR characters from the
> program output for the tests.  Let me know if it flies ...

My first review, just from looking at sources:

In main(), getopt_long must return -1, but EOF is not guaranteed to be -1.  
Don't propagate the bad habit of comparing the return of getopt_long against 
EOF.

I would scrub the code for uses of (int *)0 and use NULL instead; it just looks 
nicer to use NULL when you mean a null pointer.

You need to make sure that 'hello --help --version' is different than 'hello --
version --help'; right now, --help always wins.

-- 
Eric Blake