Re: c-ctype, inttostr, intprops module license

[Bruno Haible]

Paul Eggert wrote:
> I should have also said: I changed it to LGPL.

Thanks. The remaining warnings from "gnulib-tool --create-testdir" are:

module argp depends on a module with an incompatible license: dirname
module argp depends on a module with an incompatible license: exit
module argp depends on a module with an incompatible license: exitfail
module argp depends on a module with an incompatible license: inline
module argp depends on a module with an incompatible license: xalloc
module argp depends on a module with an incompatible license: xalloc-die
module argp depends on a module with an incompatible license: xstrndup
module canon-host depends on a module with an incompatible license: intprops
module euidaccess depends on a module with an incompatible license: exit
module euidaccess depends on a module with an incompatible license: exitfail
module euidaccess depends on a module with an incompatible license: group-member
module euidaccess depends on a module with an incompatible license: inline
module euidaccess depends on a module with an incompatible license: xalloc
module euidaccess depends on a module with an incompatible license: xalloc-die
module fts-lgpl depends on a module with an incompatible license: chdir-long
module fts-lgpl depends on a module with an incompatible license: chown
module fts-lgpl depends on a module with an incompatible license: d-ino
module fts-lgpl depends on a module with an incompatible license: dirname
module fts-lgpl depends on a module with an incompatible license: exit
module fts-lgpl depends on a module with an incompatible license: exitfail
module fts-lgpl depends on a module with an incompatible license: fcntl-safer
module fts-lgpl depends on a module with an incompatible license: getcwd
module fts-lgpl depends on a module with an incompatible license: inline
module fts-lgpl depends on a module with an incompatible license: intprops
module fts-lgpl depends on a module with an incompatible license: lchown
module fts-lgpl depends on a module with an incompatible license: openat
module fts-lgpl depends on a module with an incompatible license: save-cwd
module fts-lgpl depends on a module with an incompatible license: unistd-safer
module fts-lgpl depends on a module with an incompatible license: xalloc
module fts-lgpl depends on a module with an incompatible license: xalloc-die
module fts-lgpl depends on a module with an incompatible license: xgetcwd
module fts-lgpl depends on a module with an incompatible license: xstrndup
module getaddrinfo depends on a module with an incompatible license: intprops
module glob depends on a module with an incompatible license: d-type
module inttostr depends on a module with an incompatible license: intprops
module obstack depends on a module with an incompatible license: exit
module obstack depends on a module with an incompatible license: exitfail

This boils down to the following issues:

module argp depends on a module with an incompatible license: dirname
module euidaccess depends on a group-member which depends on xalloc
module fts-lgpl depends on a module with an incompatible license: openat
module getaddrinfo depends on a module with an incompatible license: intprops
module glob depends on a module with an incompatible license: d-type
module inttostr depends on a module with an incompatible license: intprops
module obstack depends on a module with an incompatible license: exitfail

According to my rule of thumb
  "if something is usable in libraries, we can put it under LGPL",
  "if something uses exit, or xmalloc, or error, it is not usable in libraries"

I would propose:

- argp: Either decide that argp should be GPL, or rework the 2006-01-21
  patch to lib/argp-namefrob.h so that it doesn't use dirname any more,

- euidaccess: change group-member.c so that it doesn't use xmalloc. If the
  memory allocation fails, let group_member() return -1 with errno = ENOMEM.
  Jim, would you accept patches to that effect?

- fts-lgpl & openat: no opinion. Jim, Paul?

- getaddrinfo, inttostr: Paul, can you agree to put intprops under LGPL?

- glob: d-type has no source code in lib/, therefore whether it has a GPL
  or LGPL license statement does not matter. Jim?

- inline: Likewise, should be changed to LGPL.

- obstack: If someone was to use/assign the obstack_exit_failure variable
  declared in obstack.h, he will get a link error. So I propose to move
  the "#define obstack_exit_failure exit_failure" from obstack.c to
  obstack.h. Then we can remove the dependency to exitfail.

Paul Eggert writes:
> I haven't waded through that whole list, but I'm a bit antsy about
> wholesale conversion of gnulib to the LGPL.

Noone is requesting that. Everything that calls xmalloc will stay GPL. The
only changes of lib/ code to LGPL that are being requested are for
group-member, intprops and possibly openat. The rest are mistakes that crept
in during the last few months.

Bruno