Re: Building m4 on BSDI 4.0.1

[Bruno Haible]

Eric Blake wrote:
> 2007-01-12  Eric Blake  <address@hidden>
> 
>       Provide a robust <wchar.h>.  Further simplifications are now
>       possible in other modules, but not included here.
>       * modules/wchar: New module.
>       * m4/wchar.m4: New file.
>       * lib/wchar_.h: Likewise.
>       * modules/mbchar (Depends-on): Depend on wchar, as the first use
>       of the new module.
>       * MODULES.html.sh (Wide character manipulation): Rename
>       section, and document wchar module.

Thanks. Looks fine, except 2 nits:
- The sections in MODULES.html.sh are named after the corresponding sections
  in ISO C 99. Therefore please introduce a new section, like this:

*** MODULES.html.sh     9 Jan 2007 16:14:04 -0000       1.170
--- MODULES.html.sh     12 Jan 2007 16:52:01 -0000
***************
*** 1844,1849 ****
--- 1844,1859 ----
    func_module strtoumax
    func_end_table
  
+   element="Extended multibyte and wide character utilities <wchar.h>"
+   element=`printf "%s" "$element" | sed -e "$sed_lt" -e "$sed_gt"`
+   func_section_wrap isoc_sup_wchar
+   func_wrap H3
+   func_echo "$element"
+ 
+   func_begin_table
+   func_module wchar
+   func_end_table
+ 
    element="Wide character classification and mapping utilities <wctype.h>"
    element=`printf "%s" "$element" | sed -e "$sed_lt" -e "$sed_gt"`
    func_section_wrap isoc_sup_wctype


- Too much protection:

+  if test X"$gl_cv_header_wchar_h_standalone" = Xyes; then

  The variable gl_cv_header_wchar_h_standalone here must have the value yes
  or no. Otherwise it's a typo, and shouldn't be hidden. So it's simpler to
  write
    if test $gl_cv_header_wchar_h_standalone = yes; then

Bruno