Re: Use "$(MKDIR_P) sys", not race-prone "test -d sys || mkdir sys".

[James Youngman]

On 1/22/07, Simon Josefsson <address@hidden> wrote:
> "James Youngman" <address@hidden> writes:
>
> > However, I think the problem is that on this system, the Makefile.in
> > file is not actually using @MKDIR_P@ :-
>
> Yes, I still get the same problem.  I have tried Bruno's patch, but it
> makes no difference.  The problem seems indeed to be that Makefile.in
> doesn't use @MKDIR_P@ at all:

Nod.   The following patch fixes the problem.  I'm not sure if it is
the *right* fix for the problem, since I have only been working with
Autoconf/Automake macros for ten years, and so I don't understand it
well enough yet.

2007-01-22  James Youngman  <address@hidden>

       * m4/gnulib-common.m4 (AC_PROG_MKDIR_P): If AC_PROG_MKDIR_P
       is already provided, call AC_SUBST on MKDIR_P anyway, since
       the version of AC_PROG_MKDIR_P in Autoconf-2.61 (at least)
       doesn't do that.

Index: m4/gnulib-common.m4
===================================================================
RCS file: /sources/gnulib/gnulib/m4/gnulib-common.m4,v
retrieving revision 1.2
diff -p -u -r1.2 gnulib-common.m4
--- m4/gnulib-common.m4 22 Jan 2007 00:13:19 -0000      1.2
+++ m4/gnulib-common.m4 22 Jan 2007 10:02:17 -0000
@@ -14,8 +14,13 @@ AC_DEFUN([gl_MODULE_INDICATOR],

# AC_PROG_MKDIR_P
# is a backport of autoconf-2.60's AC_PROG_MKDIR_P.
-# Remove this macro when we can assume autoconf >= 2.60.
-m4_ifdef([AC_PROG_MKDIR_P], [], [
+# We also call AC_SUBST on MKDIR_P, which Autoconf 2.61
+# doesn't want to do.
+# Remove the else part of this macro when we can
+# assume autoconf >= 2.60.
+m4_ifdef([AC_PROG_MKDIR_P], [
+  AC_SUBST([MKDIR_P])
+  ], [
  AC_DEFUN([AC_PROG_MKDIR_P],
    [AC_REQUIRE([AM_PROG_MKDIR_P])dnl defined by automake
     MKDIR_P='$(mkdir_p)'