Re: [bug-gnulib] Re: FYI, utimens was missing a dependency on timespec

[Bruno Haible]

Eric Blake wrote:
> 2007-02-23  Eric Blake  <address@hidden>
> 
>       * lib/getdate.h (includes):  Include <time.h>, not "timespec.h".
>       * lib/stat-time.h (includes): Likewise.
>       * lib/utimecmp.c (includes): Likewise.
>       * lib/utimens.h (includes): Likewise.
>       * lib/getdate.y (includes): Also include "timespec.h" for use
>       internal to the module.
>       * modules/utimens (Depends-on): Revert yesterday's patch.
>       * modules/nanosleep (Depends-on): Add missing dependency.

The two modules 'utimens' and 'utimecmp' still fail to build even on glibc
systems, according to http://autobuild.josefsson.org/gnulib/.

Here's a proposed fix:


2007-02-28  Bruno Haible  <address@hidden>

        * m4/utimecmp.m4 (gl_UTIMECMP): Don't require gl_TIMESPEC.
        * m4/utimens.m4 (gl_UTIMENS): Likewise.

--- m4/utimecmp.m4      21 Aug 2006 21:46:31 -0000      1.4
+++ m4/utimecmp.m4      28 Feb 2007 23:32:42 -0000
@@ -1,5 +1,5 @@
-#serial 2
-dnl Copyright (C) 2004, 2005, 2006 Free Software Foundation, Inc.
+#serial 3
+dnl Copyright (C) 2004, 2005, 2006, 2007 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
 dnl with or without modifications, as long as this notice is preserved.
@@ -9,7 +9,6 @@
   AC_LIBOBJ([utimecmp])
 
   dnl Prerequisites of lib/utimecmp.c.
-  AC_REQUIRE([gl_TIMESPEC])
   AC_REQUIRE([gl_FUNC_UTIMES])
   :
 ])
--- m4/utimens.m4       21 Aug 2006 21:46:31 -0000      1.6
+++ m4/utimens.m4       28 Feb 2007 23:32:42 -0000
@@ -1,4 +1,4 @@
-dnl Copyright (C) 2003, 2004, 2005, 2006 Free Software Foundation, Inc.
+dnl Copyright (C) 2003, 2004, 2005, 2006, 2007 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
 dnl with or without modifications, as long as this notice is preserved.
@@ -8,7 +8,6 @@
   AC_LIBOBJ([utimens])
 
   dnl Prerequisites of lib/utimens.c.
-  AC_REQUIRE([gl_TIMESPEC])
   AC_REQUIRE([gl_FUNC_UTIMES])
   AC_REQUIRE([gl_CHECK_TYPE_STRUCT_TIMESPEC])
   AC_REQUIRE([gl_CHECK_TYPE_STRUCT_UTIMBUF])