Re: Building universal binaries makes 'check' fail

[Paul Eggert]

Elias Pipping <address@hidden> writes:

> autoconf fails for me with
>
>     177: AC_C_BIGENDIAN  FAILED (semantics.at:478)

Thanks for testing this.  I have installed the following additional
patch, which I hope fixes your problem.  It also fixes the misspelling
noted by Paolo Bonzini.  Please give it a try when you have the time.

2007-02-28  Paul Eggert  <address@hidden>

        * lib/autoconf/c.m4 (AC_C_BIGENDIAN): Fix typo "__LITLE_ENDIAN__".
        Problem reported by Paolo Bonzini in:
        http://lists.gnu.org/archive/html/autoconf-patches/2007-02/msg00024.html
        * tests/semantics.at (AC_C_BIGENDIAN): Don't reject hosts that have
        universal binaries.  Problem reported by Elias Pipping.

Index: lib/autoconf/c.m4
===================================================================
RCS file: /cvsroot/autoconf/autoconf/lib/autoconf/c.m4,v
retrieving revision 1.243
diff -u -p -r1.243 c.m4
--- lib/autoconf/c.m4   28 Feb 2007 00:03:33 -0000      1.243
+++ lib/autoconf/c.m4   1 Mar 2007 00:18:25 -0000
@@ -1384,9 +1384,10 @@ AC_DEFUN([AC_C_BIGENDIAN],
     # See if __BIG_ENDIAN__ or __LITTLE_ENDIAN__ is defined.
     AC_COMPILE_IFELSE(
       [AC_LANG_SOURCE(
-        [[#if ! (defined __BIG_ENDIAN__ || defined __LITLE_ENDIAN__)
+        [[#if ! (defined __BIG_ENDIAN__ || defined __LITTLE_ENDIAN__)
            neither is defined;
          #endif
+         typedef int dummy;
         ]])],
       [ac_cv_c_bigendian=universal])
     if test $ac_cv_c_bigendian = unknown; then
Index: tests/semantics.at
===================================================================
RCS file: /cvsroot/autoconf/autoconf/tests/semantics.at,v
retrieving revision 1.59
diff -u -p -r1.59 semantics.at
--- tests/semantics.at  1 Dec 2006 19:36:56 -0000       1.59
+++ tests/semantics.at  1 Mar 2007 00:18:25 -0000
@@ -2,7 +2,7 @@

 AT_BANNER([Semantics.])

-# Copyright (C) 2000, 2001, 2002, 2004, 2005, 2006 Free Software
+# Copyright (C) 2000, 2001, 2002, 2004, 2005, 2006, 2007 Free Software
 # Foundation, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
@@ -470,7 +470,11 @@ AT_KEYWORDS([cross])
 # cross-compiling or not.

 _AT_CHECK_AC_MACRO(
-  [[AC_C_BIGENDIAN([ac_endian=big],[ac_endian=little],[ac_endian=unknown])
+  [[AC_C_BIGENDIAN(
+      [ac_endian=big],
+      [ac_endian=little],
+      [ac_endian=unknown],
+      [ac_endian=universal])
    echo $ac_endian > at-endian
 ]])

@@ -479,7 +483,11 @@ _AT_CHECK_AC_MACRO(
   [[# Force cross compiling.
    cross_compiling=yes
    ac_tool_warned=yes
-   AC_C_BIGENDIAN([ac_endian=big],[ac_endian=little],[ac_endian=unknown])
+   AC_C_BIGENDIAN(
+     [ac_endian=big],
+     [ac_endian=little],
+     [ac_endian=unknown],
+     [ac_endian=universal])
    ac_prevendian=`cat at-endian`
    # Check that we have found the same result as in the previous run
    # or unknown (because the cross-compiling check is allowed to fail;
@@ -490,7 +498,8 @@ _AT_CHECK_AC_MACRO(
    fi
 ]])

-# Make sure AC_C_BIGENDIAN with no argument will define WORDS_BIGENDIAN
+# Make sure AC_C_BIGENDIAN with no argument will create a config.h template
+# containing "WORDS_BIGENDIAN".
 AT_CONFIGURE_AC([[AC_C_BIGENDIAN]])
 # --force is necessary, the computer might be too fast.
 AT_CHECK_AUTOHEADER([--force])