bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: time_r.h -> time_.h


From: Paul Eggert
Subject: Re: time_r.h -> time_.h
Date: Fri, 02 Mar 2007 13:31:39 -0800
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux)

Bruno Haible <address@hidden> writes:

> ! Another reason why @file{config.h} must be included before any other
> ! include file is that it may define macros like @samp{_GNU_SOURCE}
> ! or @samp{_FILE_OFFSET_BITS} which, on glibc systems, have an effect only
> ! if defined before the first system header file is included.

Thanks.  A nit: that wording is a bit too optimistic, since those
macros in some cases do have an effect if defined after the first
system header is included.  I reworded it as follows:

2007-03-02  Paul Eggert  <address@hidden>

        * doc/gnulib-tool.texi (Initial import): Reword description of
        _FILE_OFFSET_BITS and _GNU_SOURCE, since they sometimes have a
        limited effect even if defined after the first system include.

--- doc/gnulib-tool.texi        2 Mar 2007 01:18:29 -0000       1.12
+++ doc/gnulib-tool.texi        2 Mar 2007 21:29:57 -0000
@@ -235,10 +235,9 @@ file.  That way, for example, if @file{c
 @samp{restrict} to be the empty string on a pre-C99 host, or a macro
 like @samp{_FILE_OFFSET_BITS} that affects the layout of data
 structures, the definition is consistent for all include files.
-Another reason why @file{config.h} must be included before any other
-include file is that it may define macros like @samp{_GNU_SOURCE}
-or @samp{_FILE_OFFSET_BITS} which, on glibc systems, have an effect only
-if defined before the first system header file is included.
+Also, on some platforms macros like @samp{_FILE_OFFSET_BITS} and
address@hidden may be ineffective, or may have only a limited
+effect, if defined after the first system header file is included.

 A final word of warning: Gnulib currently assumes it will be
 responsible for @emph{all} functions that end up in the Autoconf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]