[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: dummy: fix for Solaris compiler
From: |
Bruno Haible |
Subject: |
Re: dummy: fix for Solaris compiler |
Date: |
Fri, 16 Mar 2007 01:52:42 +0100 |
User-agent: |
KMail/1.5.4 |
James Youngman wrote:
> On 3/11/07, Bruno Haible <address@hidden> wrote:
> [...]
> > + #ifdef __sun
> > + /* This declaration ensures that the library will export at least 1
> > symbol. */
> > + int dummy;
> > + #else
> [...]
>
> Could we maybe pick an external symbol name that's less likely to
> clash?
The 'dummy' module is hardly used in practice, because it gets disabled
as soon as you have at least one gnulib module with an unconditional
lib_SOURCES augmentation. But anyway, it doesn't cost much to choose a
different symbol. I applied this:
2007-03-15 Bruno Haible <address@hidden>
* lib/dummy.c (gl_dummy_symbol): Renamed from 'dummy'.
Reported by James Youngman <address@hidden>.
--- lib/dummy.c 11 Mar 2007 22:28:43 -0000 1.4
+++ lib/dummy.c 16 Mar 2007 00:52:20 -0000
@@ -36,7 +36,7 @@
#ifdef __sun
/* This declaration ensures that the library will export at least 1 symbol. */
-int dummy;
+int gl_dummy_symbol;
#else
/* This declaration is solely to ensure that after preprocessing
this file is never empty. */