bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: stdint and cygwin bug


From: Eric Blake
Subject: Re: stdint and cygwin bug
Date: Wed, 04 Apr 2007 21:40:59 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.10) Gecko/20070221 Thunderbird/1.5.0.10 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Bruno Haible on 4/4/2007 5:47 PM:
> 
> OTOH, if it causes tests/test-stdint.c to not compile, then it is best
> to mark the part of the test that doesn't work with "#ifndef __CYGWIN__".
> So that the other tests can still be executed without manual intervention.

$ ./gnulib-tool --with-tests --test stdint
...
gcc -DHAVE_CONFIG_H -I. -I../../gltests  -I. -I../../gltests -I..
- -I../../gltests/.. -I../gllib -I../../gltests/../gllib   -g -O2 -MT
test-stdint.o -MD -MP -MF .deps/test-stdint.Tpo -c -o test-stdint.o
../../gltests/test-stdint.c
../../gltests/test-stdint.c:311: error: negative width in bit-field
`verify_error_if_negative_size__'
../../gltests/test-stdint.c:312: error: negative width in bit-field
`verify_error_if_negative_size__'
make[4]: *** [test-stdint.o] Error 1

I'd rather not make the test conditional on __CYGWIN__, because then no
one will remember to uncomment it when Cygwin is fixed.  I don't know how
much longer it will be before cygwin 1.7.0 is released.  So I'm checking
this in instead.

2007-04-04  Eric Blake  <address@hidden>

        * m4/stdint.m4 (gl_STDINT_H): Detect WINT_MAX bug in cygwin
        1.5.x.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGFG/K84KuGfSFAYARApCVAJ4sGLfVhbGS5uLQZB/a1Sb0G3YEWQCgtmt6
R8ZsMQ3jzHdpZuwvV24J7bY=
=YQqm
-----END PGP SIGNATURE-----
Index: m4/stdint.m4
===================================================================
RCS file: /sources/gnulib/gnulib/m4/stdint.m4,v
retrieving revision 1.27
diff -u -p -r1.27 stdint.m4
--- m4/stdint.m4        16 Jan 2007 17:56:41 -0000      1.27
+++ m4/stdint.m4        5 Apr 2007 03:37:23 -0000
@@ -1,4 +1,4 @@
-# stdint.m4 serial 22
+# stdint.m4 serial 23
 dnl Copyright (C) 2001-2002, 2004-2007 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -143,11 +143,11 @@ uintptr_t h = UINTPTR_MAX;
 intmax_t i = INTMAX_MAX;
 uintmax_t j = UINTMAX_MAX;
 struct s {
-  int check_PTRDIFF: PTRDIFF_MIN < 0 && 0 < PTRDIFF_MAX ? 1 : -1;
-  int check_SIG_ATOMIC: SIG_ATOMIC_MIN <= 0 && 0 < SIG_ATOMIC_MAX ? 1 : -1;
-  int check_SIZE: 0 < SIZE_MAX ? 1 : -1;
-  int check_WCHAR: WCHAR_MIN <= 0 && 0 < WCHAR_MAX ? 1 : -1;
-  int check_WINT: WINT_MIN <= 0 && 0 < WINT_MAX ? 1 : -1;
+  int check_PTRDIFF: PTRDIFF_MIN < (ptrdiff_t) 0 && (ptrdiff_t) 0 < 
PTRDIFF_MAX ? 1 : -1;
+  int check_SIG_ATOMIC: SIG_ATOMIC_MIN <= (sig_atomic_t) 0 && (sig_atomic_t) 0 
< SIG_ATOMIC_MAX ? 1 : -1;
+  int check_SIZE: (size_t) 0 < SIZE_MAX ? 1 : -1;
+  int check_WCHAR: WCHAR_MIN <= (wchar_t) 0 && (wchar_t) 0 < WCHAR_MAX ? 1 : 
-1;
+  int check_WINT: WINT_MIN <= (wint_t) 0 && (wint_t) 0 < WINT_MAX ? 1 : -1;
 
   /* Detect bugs in glibc 2.4 and Solaris 10 stdint.h, among others.  */
   int check_UINT8_C:

reply via email to

[Prev in Thread] Current Thread [Next in Thread]