Re: HAVE_CONFIG_H in tests [was: allocsa compiler warning]

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Bruno Haible on 5/28/2007 10:02 AM:
> Eric Blake wrote:
>> extend to the unit tests the same assumptions that
>> the rest of gnulib makes (that is, that <config.h> is unconditionally
>> available).  I'm leaning towards the latter, by removing all tests of
>> #ifdef HAVE_CONFIG_H from the testsuites - is that okay?
> 
> Yes, this is ok. Somehow the test source codes continued to use the older
> coding conventions. Thanks!

Done.  The patch was mechanical, so I'm not attaching it:

cd tests
for f in `grep -l HAVE_CONFIG_H *.c` ; do echo $f;
 sed -i '/HAVE_CONFIG_H/,/endif/ c\
#include <config.h>
' $f ; done

2007-05-28  Eric Blake  <address@hidden>

        Unconditionally include <config.h> in unit tests.
        * tests/test-alloca-opt.c: Remove #ifdef HAVE_CONFIG_H.
        * tests/test-allocsa.c, tests/test-arcfour.c,
        tests/test-arctwo.c, tests/test-argmatch.c, tests/test-argp.c,
        tests/test-array_list.c, tests/test-array_oset.c,
        tests/test-atexit.c, test-avltree_list.c, test-avltree_oset.c,
        test-avltreehash_list.c, test-base64.c, test-binary-io.c,
        test-c-ctype.c, test-c-strcasecmp.c, test-c-strcasestr.c,
        test-c-strncasecmp.c, test-c-strstr.c, test-canonicalize-lgpl.c,
        test-carray_list.c, test-crc.c, test-des.c, test-dirname.c,
        test-fflush.c, test-fprintf-posix.c, test-gc-arcfour.c,
        test-gc-arctwo.c, test-gc-des.c, test-gc-hmac-md5.c,
        test-gc-hmac-sha1.c, test-gc-md2.c, test-gc-md4.c, test-gc-md5.c,
        test-gc-pbkdf2-sha1.c, test-gc-rijndael.c, test-gc-sha1.c,
        test-gc.c, test-getpass.c, test-hmac-md5.c, test-hmac-sha1.c,
        test-iconv.c, test-linked_list.c, test-linkedhash_list.c,
        test-lock.c, test-mbscasecmp.c, test-mbscasestr1.c,
        test-mbscasestr2.c, test-mbscasestr3.c, test-mbscasestr4.c,
        test-mbschr.c, test-mbscspn.c, test-mbsncasecmp.c, test-mbspbrk.c,
        test-mbspcasecmp.c, test-mbsrchr.c, test-mbsspn.c, test-mbsstr1.c,
        test-mbsstr2.c, test-mbsstr3.c, test-md2.c, test-md4.c,
        test-md5.c, test-memmem.c, test-printf-posix.c,
        test-rbtree_list.c, test-rbtree_oset.c, test-rbtreehash_list.c,
        test-read-file.c, test-rijndael.c, test-snprintf-posix.c,
        test-snprintf.c, test-sprintf-posix.c, test-stdint.c,
        test-strcasestr.c, test-striconv.c, test-striconveh.c,
        test-striconveha.c, test-tls.c, test-vasnprintf-posix.c,
        test-vasnprintf-posix2.c, test-vasnprintf.c,
        test-vasprintf-posix.c, test-vasprintf.c, test-verify.c,
        test-vfprintf-posix.c, test-vprintf-posix.c,
        test-vsnprintf-posix.c, test-vsnprintf.c, test-vsprintf-posix.c,
        test-xvasprintf.c: Likewise.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGWwhS84KuGfSFAYARAruaAJoCQASBIaTGgriBTkhvVvuMs8/3mwCePtDs
lk8KJ45dw8dzd/ah+3NSQvk=
=dW+3
-----END PGP SIGNATURE-----