[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Eliminate one way canonicalize_filename_mode could exit.
From: |
Jim Meyering |
Subject: |
Re: Eliminate one way canonicalize_filename_mode could exit. |
Date: |
Tue, 19 Jun 2007 08:45:02 +0200 |
Paul Eggert <address@hidden> wrote:
> Jim Meyering <address@hidden> writes:
>
>> This proposed change removes the sole use of xreadlink_with_size:
>>
>> Eliminate one way canonicalize_filename_mode could exit.
>> * lib/canonicalize.c (canonicalize_filename_mode):
>> Use mreadlink_with_size, not xreadlink_with_size.
>
> Makes sense to me.
Thanks. I applied that.
> Also, shouldn't we remove the xreadlink-with-size
> module? As far as I know, coreutils is the only program using it.
Yes, that sounds safe, since it's so new.
I've removed it:
2007-06-19 Jim Meyering <address@hidden>
xreadlink-with-size: Remove module. No longer used.
Ex-callers now use xreadlink or mreadlink-with-size.
* modules/xreadlink-with-size: Remove module.
* lib/xreadlink-with-size.c: Remove file.
* lib/xreadlink.h (xreadlink_with_size): Remove prototype.
(xreadlink): Remove inaccurate comment. The one in xreadlink.c,
just before the function definition *is* accurate.