bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: human interface change?!? [Re: xstrtol.h


From: Eric Blake
Subject: Re: human interface change?!? [Re: xstrtol.h
Date: Thu, 09 Aug 2007 21:00:30 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070728 Thunderbird/2.0.0.6 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Paul Eggert on 8/9/2007 4:04 PM:
> Jim Meyering <address@hidden> writes:
> 
>> find's locate.c uses it, too.

Actually, you would also need to bump find's gnulib-import.config to pull
in a newer date, before this matters.

> -  while ((optc = getopt_long (argc, argv, "Abcd:eEil:prsm0SwHPL", longopts, 
> (int *) 0)) != -1)
> +  while ((optc = getopt_long (argc, argv, "Abcd:eEil:prsm0SwHPL", longopts, 
> &opti)) != -1)

Didn't we decide that opti is not reset between getopt_long invocations?
Therefore, this should be:

while (1)
  {
    opti = -1;
    optc = getopt_long(...);
    if (optc == -1)
      break;
    switch (optc)
...

And you would also have to patch POTFILES.in.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGu9TO84KuGfSFAYARAuPtAJsFH9Fl1eno2B1RJi5A4xF+fVAcswCfZY9Z
kDGT8PZNmHxb5RVqBDCLA4M=
=myOH
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]