[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: printf-frexp.c evokes shadowing warning
From: |
Jim Meyering |
Subject: |
Re: printf-frexp.c evokes shadowing warning |
Date: |
Sun, 07 Oct 2007 22:24:17 +0200 |
Bruno Haible <address@hidden> wrote:
> Jim Meyering wrote:
>> printf-frexp.c evokes a shadowing warning on at least a debian unstable
>> system, and now that coreutils uses it (via vasprintf-posix), it causes
>> the "make distcheck" build to fail:
>>
>> printf-frexp.c: In function 'printf_frexp':
>> printf-frexp.c:65: error: declaration of 'exp' shadows a global declaration
>> /usr/include/bits/mathcalls.h:101: error: shadowed declaration is here
>> make[5]: *** [printf-frexp.o] Error 1
>
> As always, I remind that gnulib does not support "gcc -Werror".
This is about -Wshadow support, not -Werror.
Gnulib *does* support -Wshadow. It just so happens that
coreutils uses -Werror to enforce its own no-shadowing-warnings policy.
> But since
> it's about coreutils and since the parameter name here is a misnomer anyway,
> I'm applying this:
>
> 2007-10-07 Bruno Haible <address@hidden>
>
> Avoid gcc warnings "declaration of 'exp' shadows a global declaration".
...
Thanks.