[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: several trim bugs
From: |
Colin Watson |
Subject: |
Re: several trim bugs |
Date: |
Thu, 18 Oct 2007 12:21:41 +0100 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Thu, Oct 18, 2007 at 12:57:17PM +0200, Bruno Haible wrote:
> Thanks for reporting all this. I'm applying the appended patch to fix
> all this.
Thanks.
> Colin Watson wrote:
> > Fourthly, gcc complains:
> >
> > trim.c: In function ‘trim2’:
> > trim.c:67: warning: ‘r’ may be used uninitialized in this function
> >
> > ... and it may be that the state machine in fact renders it impossible
> > for this to be used uninitialised but this wasn't obvious to me.
>
> I added a comment with the invariant.
Oh, I stupidly misread the 'if (state == 2 && mb_isspace (mbi_cur (i)))'
branch; you're quite right, of course.
--
Colin Watson address@hidden