Re: copy_acl on IRIX

[Paul Eggert]

Jim Meyering <address@hidden> writes:

> However, a long-term (forward-looking :-) solution should
> also take into consideration the state of NFSv4 and ZFS.

Yes, I'll see if I can pry free some time to look into that.

> Either is fine with me and will work for that system,
> and you're welcome to apply either change.

Thanks, I installed this for now:

2007-10-22  Paul Eggert  <address@hidden>

        * lib/acl.c (copy_acl): Adjust to IRIX 6.5.  Problem reported
        by Bruno Haible.

diff --git a/lib/acl.c b/lib/acl.c
index 0872e45..c95a571 100644
--- a/lib/acl.c
+++ b/lib/acl.c
@@ -84,7 +84,12 @@ copy_acl (const char *src_name, int source_desc, const char 
*dst_name,
          int n = acl_entries (acl);

          acl_free (acl);
-         if (n == 3)
+         /* On most hosts an ACL is trivial if n == 3, and it cannot be
+            less than 3.  On IRIX 6.5 it is also trivial if n == -1.
+            For simplicity and safety, assume the ACL is trivial if n <= 3.
+            Also see file_has_acl.c for some of the other possibilities;
+            it's not clear whether that complexity is needed here.  */
+         if (n <= 3)
            {
              if (chmod_or_fchmod (dst_name, dest_desc, mode) != 0)
                saved_errno = errno;