bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: regex.m4 test too strict?


From: Sam Steingold
Subject: Re: regex.m4 test too strict?
Date: Thu, 01 Nov 2007 16:50:21 -0400
User-agent: Thunderbird 2.0.0.0 (X11/20070326)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Paul Eggert wrote:
> Sam Steingold <address@hidden> writes:
> 
>> # ac_use_included_regex is NOT cached, so we have to duplicate the
>> # logic of src/glm4/regex.m4!
>> case $with_included_regex in
>>   yes|no) ac_use_included_regex=$with_included_regex ;;
>>   '') case $gl_cv_func_re_compile_pattern_working in
>>     yes) ac_use_included_regex=no;;
>>     no) ac_use_included_regex=yes;;
>>   esac ;;
>> esac
>>
>> is this cheap?
> 
> Yes.

this may be cheap from the execution POV, but certainly not from the
maintenance POV.

>> and, more importantly, is this correct?!
> 
> Yes, for now.  But why not just use gl_REGEX?  It will be cheap too,
> and then you don't have to worry about its internal details changing.

I already call gl_REGEX (via gl_INIT) from the top-level configure.
if I call gl_REGEX again in subordinate configures, I will have the
concomitant #define's in both top-level config.h and subordinate
config.h, which causes problems reported in
<http://permalink.gmane.org/gmane.lisp.clisp.devel/16815> and
<http://permalink.gmane.org/gmane.lisp.clisp.devel/16824>.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHKjwNPp1Qsf2qnMcRAi4OAJ4oi3Rl57YzPpTxMMyW0W9S2T/pOQCfZHji
F8Q5sNImh08GE+khUL3pDks=
=nXFF
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]