[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: getaddrinfo: test failure on Solaris 9
From: |
Paul Eggert |
Subject: |
Re: getaddrinfo: test failure on Solaris 9 |
Date: |
Fri, 16 Nov 2007 11:25:49 -0800 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) |
In March, Bruno reported a problem with the getaddrinfo test. I
recently ran into the same problem on Solaris 8 when testing
coreutils, and I think it happens on Solaris 10 too. I installed this
patch into gnulib to work around the problem.
2007-11-16 Paul Eggert <address@hidden>
Port test-getaddrinfo to Solaris.
Problem reported by Bruno Haible in
<http://lists.gnu.org/archive/html/bug-gnulib/2007-03/msg00171.html>.
* tests/test-getaddrinfo.c (simple): Add a comment asking for an
explanation of setting 'hints'.
(SERV1, SERV2, SERV3): Don't use "http" and "https"; this doesn't
work in Solaris 10 and earlier.
diff --git a/tests/test-getaddrinfo.c b/tests/test-getaddrinfo.c
index 4148788..0624516 100644
--- a/tests/test-getaddrinfo.c
+++ b/tests/test-getaddrinfo.c
@@ -37,10 +37,13 @@ int simple (char *host, char *service)
printf ("Finding %s service %s...\n", host, service);
+ /* This initializes "hints" but does not use it. Is there a reason
+ for this? If so, please fix this comment. */
memset (&hints, 0, sizeof (hints));
hints.ai_flags = AI_CANONNAME;
hints.ai_family = AF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
+
res = getaddrinfo (host, service, 0, &ai0);
printf ("res %d: %s\n", res, gai_strerror (res));
@@ -86,12 +89,15 @@ int simple (char *host, char *service)
return 0;
}
+/* Use numbers for http and https services, rather than names, because
+ Solaris 8 /etc/services does not define these service names by
+ default. */
#define HOST1 "www.gnu.org"
-#define SERV1 "http"
+#define SERV1 "80"
#define HOST2 "www.ibm.com"
-#define SERV2 "https"
+#define SERV2 "443"
#define HOST3 "microsoft.com"
-#define SERV3 "http"
+#define SERV3 "80"
#define HOST4 "google.org"
#define SERV4 "ldap"
- Re: getaddrinfo: test failure on Solaris 9,
Paul Eggert <=