bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch for the getpagesize module


From: Bruno Haible
Subject: Re: Patch for the getpagesize module
Date: Mon, 3 Dec 2007 12:39:15 +0100
User-agent: KMail/1.5.4

Martin Lambers wrote on 2007-11-28:
> MinGW has a getpagesize() function, but does not declare it.

Strange. The mingw system I have access to does not have a getpagesize()
function. In yours, in which library is it defined? And what is your mingw
system? MSYS, Cygwin-crosscompiled, or Debian-crosscompiled?

> - Provide a getpagesize declaration if the system does not provide one
>   (needed on MinGW).
> 
> I removed the untested MSVC implementation from the previous patch.

Actually, I think it's better to treat mingw and MSVC systems the same
where possible.

The implementation that you gave in your previous patch

 #if (defined _WIN32 || defined __WIN32__) && ! defined __CYGWIN__
   SYSTEM_INFO system_info;
   GetSystemInfo (&system_info);
   return system_info.dwPageSize;

is the same as the one used in GNU clisp for 10 years, so you can assume
that it works. (And its value on 32-bit x86 platforms is 0x1000.)

I would therefore find it reasonable to create a lib/getpagesize.c file
just for this case of native Windows. What do you think?

Bruno





reply via email to

[Prev in Thread] Current Thread [Next in Thread]